[PATCH] D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`
Antonio Frighetto via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 5 06:24:07 PDT 2022
antoniofrighetto added a comment.
@probinson, sorry for late reply, it turns out that the sub-project, which this change was needed for, has been recently dismissed, so no longer needed. Also, we did not have any change of ours to provide, alongside the patch. That said, considering that the inverse function `parseArch` already supports s390x <https://github.com/llvm/llvm-project/blob/9130e471fe82afc51b5e691f1620aea09c8fbf2e/llvm/lib/Support/Triple.cpp#L478> and the proposed change is fairly minimal (besides that `getArchTypeForLLVMName` is already tested via `lookupTarget`), I'm still wondering if part of the patch (at least the case adding `s390x` arch) could be beneficial. If you think it's not, I'll close the review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122003/new/
https://reviews.llvm.org/D122003
More information about the llvm-commits
mailing list