[PATCH] D123110: [docs] Fix Kaleidoscope code example

[Roman Sokolkov via Phabricator via llvm-commits]

r7vme created this revision.
Herald added a project: All.
r7vme updated this revision to Diff 420420.
r7vme added a comment.
r7vme published this revision for review.
r7vme added a reviewer: lattner.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Ready for review


r7vme added a comment.

Hello, this is my first patch to LLVM. Let me know if anything else is needed.


- replace virtual with override
- use default like in full code example


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123110

Files:
  llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl03.rst


Index: llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl03.rst
===================================================================
--- llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl03.rst
+++ llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl03.rst
@@ -34,7 +34,7 @@
     /// ExprAST - Base class for all expression nodes.
     class ExprAST {
     public:
-      virtual ~ExprAST() {}
+      virtual ~ExprAST() = default;
       virtual Value *codegen() = 0;
     };
 
@@ -44,7 +44,7 @@
 
     public:
       NumberExprAST(double Val) : Val(Val) {}
-      virtual Value *codegen();
+      Value *codegen() override;
     };
     ...
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123110.420420.patch
Type: text/x-patch
Size: 644 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220405/575e5092/attachment.bin>