[PATCH] D122914: [Windows] Fix handling of \" in program name on cmd line.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 00:44:05 PDT 2022


simon_tatham updated this revision to Diff 420399.
simon_tatham added a comment.

Fixed a CI failure (`unreachable` in tokenizeWindowsCommandLineImpl was reached because I forgot to correctly handle an unquoted initial backslash in CommandName mode), and added an extra unit test to ensure the triggering case stays working.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122914/new/

https://reviews.llvm.org/D122914

Files:
  llvm/include/llvm/Support/CommandLine.h
  llvm/lib/Support/CommandLine.cpp
  llvm/lib/Support/Windows/Process.inc
  llvm/unittests/Support/CommandLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122914.420399.patch
Type: text/x-patch
Size: 10967 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220405/bdb526d0/attachment.bin>


More information about the llvm-commits mailing list