[PATCH] D120073: [LLD] Fix for race condition.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 21:12:20 PDT 2022


MaskRay added a comment.

I removed many `data()` call sites in ae1ba6194f09b7e310fd49cf18a2829dcbeb7f6b <https://reviews.llvm.org/rGae1ba6194f09b7e310fd49cf18a2829dcbeb7f6b>. It is likely to have minimum effect now.
That said, I think this patch still lacks justification. You can fix the issue in your downstream patch using getErrPlace which shouldn't be too difficult.
And you can call uncompress beforehand.

If we want to get rid of the uncompressedSize in data(), I think we should try doing one of the bullet points I mentioned:

> For an upstreamable patch, there are many directions:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120073/new/

https://reviews.llvm.org/D120073



More information about the llvm-commits mailing list