[PATCH] D123088: attributes: introduce allockind attr for describing allocator fn behavior

Augie Fackler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 15:17:43 PDT 2022


durin42 created this revision.
Herald added subscribers: ormris, dexonsmith, jdoerfert, steven_wu, hiraditya.
Herald added a project: All.
durin42 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I chose to encode the allockind information in a string constant because
otherwise we would get a bit of an explosion of keywords to deal with
the possible permutations of allocation function types.

I'm not sure that CodeGen.h is the correct place for this enum, but it
seemed to kind of match the UWTableKind enum so I put it in the same
place. Constructive suggestions on a better location most certainly
encouraged.

Depends on D123087 <https://reviews.llvm.org/D123087>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123088

Files:
  llvm/include/llvm/Analysis/MemoryBuiltins.h
  llvm/include/llvm/AsmParser/LLParser.h
  llvm/include/llvm/AsmParser/LLToken.h
  llvm/include/llvm/Bitcode/LLVMBitCodes.h
  llvm/include/llvm/IR/Attributes.h
  llvm/include/llvm/IR/Attributes.td
  llvm/include/llvm/Support/CodeGen.h
  llvm/lib/AsmParser/LLLexer.cpp
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/BitcodeReader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/IR/AttributeImpl.h
  llvm/lib/IR/Attributes.cpp
  llvm/lib/Transforms/Utils/CodeExtractor.cpp
  llvm/test/Bitcode/compatibility.ll

STAMPS
actor(@durin42) application(Differential) author(@durin42) herald(H224) herald(H225) herald(H343) herald(H347) herald(H428) herald(H576) herald(H615) herald(H638) herald(H678) herald(H688) herald(H692) herald(H787) herald(H864) monogram(D123088) object-type(DREV) phid(PHID-DREV-mg3ug5mi477is2n6kt7u) revision-repository(rG) revision-status(needs-review) subscriber(@dexonsmith) subscriber(@hiraditya) subscriber(@jdoerfert) subscriber(@llvm-commits) subscriber(@ormris) subscriber(@steven_wu) tag(#all) tag(#llvm) via(conduit)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123088.420327.patch
Type: text/x-patch
Size: 14268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220404/497ca039/attachment.bin>


More information about the llvm-commits mailing list