[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked an inline comment as done.
hctim added inline comments.


================
Comment at: clang/test/Driver/memtag-ld.c:36
+
+// CHECK-ASYNC: ld{{.*}} "-memtag-mode=async"
+// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode=
----------------
MaskRay wrote:
> This will be easier to read if you make the strings after `:` aligned.
> 
> Is `-memtag-mode=async` `--android-memtag-mode=async` now?
thanks for the catch


================
Comment at: clang/test/Driver/memtag-ld.c:38
+// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode=
+// CHECK-HEAP: "--android-memtag-heap"
+// CHECK-NO-HEAP-NOT: "--android-memtag-heap"
----------------
MaskRay wrote:
> Prefer `CHECK-HEAP-SAME` to `CHECK-HEAP` whenever feasible.
There's no other CHECK-HEAP before this, so `-SAME` not possible


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118948/new/

https://reviews.llvm.org/D118948