[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Julian Lettner via Phabricator via llvm-commits]

yln added inline comments.


================
Comment at: llvm/utils/lit/lit/formats/googletest.py:170
+
+        remove_gtest(discovered_tests)
+        gtests = [t for t in selected_tests if t.gtest_json_file]
----------------
ychen wrote:
> yln wrote:
> > This will still change the passed-in lists, right?
> That's right. It is by reference.
I meant: please change this function so it builds new lists and leaves the passed-in ones unchanged.  Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251