[PATCH] D122949: [AIX] XFAIL tests because of no big archive writer operation support

Mon Apr 4 10:48:25 PDT 2022

Jake-Egan added a comment.

In D122949#3425633 <https://reviews.llvm.org/D122949#3425633>, @jhenderson wrote:

> In D122949#3424498 <https://reviews.llvm.org/D122949#3424498>, @Jake-Egan wrote:
>
>> The patch D122746 <https://reviews.llvm.org/D122746> `XFAIL`ed the archive writer tests in llvm/test/Object and llvm/test/tools/llvm-ar, but it missed the 5 tests in this patch. There aren't any other tests that need to be dealt with at the moment. I agree `UNSUPPORTED` probably makes more sense, but I was trying to be consistent with the other patch.
>
> I considered this when reviewing, but I actually think XFAIL is better, because there are reasonably near term plans to implement the functionality. Marking as UNSUPPORTED would mean the tests won't start XPASSing at that point, meaning they may never be run for the new format, even though they should be.
>
> That being said, for tests not testing the archiver, but rather testing a different tool, you should instead use the explicit `--format` option, so that they continue working on AIX. Note that this is what the original patch did.

In that case, I can post a patch to use `--format` instead.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122949/new/

https://reviews.llvm.org/D122949