[PATCH] D122965: Corrected A Command
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 4 08:23:20 PDT 2022
aaron.ballman added a comment.
In D122965#3426412 <https://reviews.llvm.org/D122965#3426412>, @aaron.ballman wrote:
> In D122965#3426403 <https://reviews.llvm.org/D122965#3426403>, @ps-19 wrote:
>
>> Can anyone please review the patch?
>
> FYI: please only ping the patch after about a week has gone by with no review (https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted). Reviewers get to reviews as we're able to, but it's quite common for there to be a few days between reviews.
>
> That said, the changes here LGTM (though I can't fathom why this was a CodeGen test to begin with -- it looks like it should have been a Parser or Sema test and using `-verify`)
Oops, forgot to ask -- what name and email address would you like for patch attribution?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122965/new/
https://reviews.llvm.org/D122965
More information about the llvm-commits
mailing list