[PATCH] D122990: Added new file & improved inclusivity

Priyansh Singh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 08:13:55 PDT 2022


ps-19 marked 8 inline comments as done.
ps-19 added a comment.

Can anyone please review the differential.



================
Comment at: README.md:3
 
-This directory and its sub-directories contain source code for LLVM,
 a toolkit for the construction of highly optimized compilers,
----------------
jpienaar wrote:
> I'd split this out: this is an LLVM change the rest is specific to MLIR
Yes, changes are made in MLIR repository much more than LLVM.


================
Comment at: README.md:3
 
-This directory and its sub-directories contain source code for LLVM,
+This directory and its sub-directories contains the source code for LLVM,
 a toolkit for the construction of highly optimized compilers,
----------------
xbolva00 wrote:
> contain seems ok, no?
As a proof. Both are completely correct, if you think it is not i can edit please give your feedback.

{F22652958}
{F22652964}


================
Comment at: mlir/README.md:1
-# Multi-Level Intermediate Representation
+# Overview
+The MLIR project is a novel approach to building reusable and extensible compiler infrastructure. MLIR aims to address software fragmentation, improve compilation for heterogeneous hardware, significantly reduce the cost of building domain specific compilers, and aid in connecting existing compilers together.
----------------
https://reviews.llvm.org/p/jpienaar/  i hope i satisfied your remark.
Thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122990/new/

https://reviews.llvm.org/D122990



More information about the llvm-commits mailing list