[PATCH] D122887: [llvm-pdbutil] Move global state (Filters) inside LinePrinter class.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 05:04:33 PDT 2022


CarlosAlbertoEnciso updated this revision to Diff 420144.
CarlosAlbertoEnciso added a comment.

Address feedback from @aganea:

Main points:

- Use the `Printer` which is already in `HeaderScope`.
- Keep `shouldDumpSymbolGroup` in the original location and pass `Filters` as argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122887/new/

https://reviews.llvm.org/D122887

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h
  llvm/include/llvm/DebugInfo/PDB/Native/LinePrinter.h
  llvm/lib/DebugInfo/PDB/Native/InputFile.cpp
  llvm/lib/DebugInfo/PDB/Native/LinePrinter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122887.420144.patch
Type: text/x-patch
Size: 4987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220404/9859c4cc/attachment.bin>


More information about the llvm-commits mailing list