[PATCH] D120104: [AArch64] Split fuse-literals feature

Mon Apr 4 03:05:48 PDT 2022

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks for the update. I think this should be safe to enable by default in terms of performance. We may want to add it to other CPUs too, but that should probably be sorted out separately.

LGTM.

================
Comment at: llvm/lib/Target/AArch64/AArch64.td:1075
   // mentioning the new system register names in assembly.
-  list<SubtargetFeature> Generic = [FeatureFPARMv8, FeatureNEON, FeatureETE];
+  list<SubtargetFeature> Generic = [FeatureFPARMv8, FeatureNEON, FeatureETE, FeatureFuseAdrpAdd];
 }
----------------
Can you format this line - just to make sure it doesn't get too long.

And maybe add to the comment, that we enable FeatureFuseAdrpAdd under Generic to allow linker merging optimizations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120104/new/

https://reviews.llvm.org/D120104