[PATCH] D123017: [VPlan] Remove unused native utilities incompatible with nested regions.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 02:45:21 PDT 2022


fhahn created this revision.
fhahn added reviewers: Ayal, gilr, rengolin, sguggill.
Herald added subscribers: tschuett, psnobl, rogfer01, bollu, kuhar, hiraditya, mgorny.
Herald added a project: All.
fhahn requested review of this revision.
Herald added a subscriber: vkmr.
Herald added a project: LLVM.

The implementations of VPlanDominatorTree, VPlanLoopInfo and VPlanPredicator
are all incompatible with modeling loops in VPlans as region without
explicit back-edges.

Those pieces are not actively used and only exercised by a few gtest
unit tests. They are at the moment blocking progress towards unifying
the native and inner-loop vectorizer paths in D121624 <https://reviews.llvm.org/D121624> and D123005 <https://reviews.llvm.org/D123005>.

I think we should not block forward progress on unused pieces of code,
so this patch removes the utilities for now. The plan is to re-introduce
them as needed in a way that is compatible with the unified VPlan scheme
used in both the inner loop vectorizer and the native path.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123017

Files:
  llvm/lib/Transforms/Vectorize/CMakeLists.txt
  llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/lib/Transforms/Vectorize/VPlan.h
  llvm/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
  llvm/lib/Transforms/Vectorize/VPlanLoopInfo.h
  llvm/lib/Transforms/Vectorize/VPlanPredicator.cpp
  llvm/lib/Transforms/Vectorize/VPlanPredicator.h
  llvm/unittests/Transforms/Vectorize/CMakeLists.txt
  llvm/unittests/Transforms/Vectorize/VPlanDominatorTreeTest.cpp
  llvm/unittests/Transforms/Vectorize/VPlanLoopInfoTest.cpp
  llvm/unittests/Transforms/Vectorize/VPlanPredicatorTest.cpp
  llvm/unittests/Transforms/Vectorize/VPlanTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123017.420125.patch
Type: text/x-patch
Size: 44743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220404/a96fb191/attachment.bin>


More information about the llvm-commits mailing list