[PATCH] D122965: Corrected A Command
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 3 14:38:01 PDT 2022
smeenai added a comment.
Thanks for the typo fix!
================
Comment at: clang/test/CodeGen/c-unicode.c:5
int \uaccess = 0;
// ALLOWED: "곎ss":
// ALLOWED-NOT: "\uaccess":
----------------
ps-19 wrote:
> Comment Line No: 5 is // ALLOWED: "곎ss": i think "곎ss" in istake here, according to google it is written in korean and i can not understand it's meaning, but it should be made more concise and readable for more user.
Given that the test is called `c-unicode.c`, I imagine it's intentional.
================
Comment at: mypatch.patch:1
+diff --git a/llvm/utils/vim/indent/llvm.vim b/llvm/utils/vim/indent/llvm.vim
+index d1d8c83d1186..75ee9ef485d4 100644
----------------
This seems like an unrelated change; can you remove it from this patch please?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122965/new/
https://reviews.llvm.org/D122965
More information about the llvm-commits
mailing list