[PATCH] D122990: Added new file & improved inclusivity

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 3 08:35:00 PDT 2022


xbolva00 added inline comments.


================
Comment at: mlir/docs/LangRef.md:842
 
-See [here](AttributesAndTypes.md) on how to define dialect attribute values.
+See [here](AttributesAndTypes.md) about how to define dialect attribute values.
 
----------------
to learn?


================
Comment at: mlir/docs/OpDefinitions.md:589
    `verifyWithRegions=0`.
-1. Custom verifier which is defined in the op and has marked `hasVerifier=1`
+1. Custom verifier which is defined in the op and has beenmarked `hasVerifier=1`
 
----------------
typo


================
Comment at: mlir/docs/PDLL.md:33
+that no longer exists.
 
 ### Why build a new language instead of improving TableGen DRR?
----------------
Wrong?

areas .. exist


================
Comment at: mlir/docs/PassManagement.md:42
         on all operations.
-*   Must not maintain any global mutable state, e.g. static variables within the
+*   Must not maintain any global mutable states, e.g. static variables within the
     source file. All mutable state should be maintained by an instance of the
----------------
Nothing wrong with existing line.


================
Comment at: mlir/docs/PassManagement.md:131
 end, a pass that may create an entity from a dialect that isn't guaranteed to
-already ne loaded must express this by overriding the `getDependentDialects()`
+already loaded, must express this by overriding the `getDependentDialects()`
 method and declare this list of Dialects explicitly.
----------------
ne is typo for be


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122990/new/

https://reviews.llvm.org/D122990



More information about the llvm-commits mailing list