[PATCH] D122990: Added new file & improved inclusivity
Jacques Pienaar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 3 05:59:06 PDT 2022
jpienaar added a comment.
> Improved Inclusivity to make it beginner-friendly
I'm not sure I see any change related to this.
================
Comment at: README.md:3
-This directory and its sub-directories contain source code for LLVM,
a toolkit for the construction of highly optimized compilers,
----------------
I'd split this out: this is an LLVM change the rest is specific to MLIR
================
Comment at: mlir/docs/LangRef.md:21
MLIR is designed to be used in three different forms: a human-readable textual
-form suitable for debugging, an in-memory form suitable for programmatic
+form suitable for debugging; an in-memory form suitable for programmatic
transformations and analysis, and a compact serialized form suitable for storage
----------------
This change doesn't make sense.
================
Comment at: mlir/docs/LangRef.md:47
-MLIR also provides an extensible framework for transformations on operations,
+MLIR also provides an extensible framework for the transformations on operations,
using familiar concepts of compiler [Passes](Passes.md). Enabling an arbitrary
----------------
Doesn't make sense.
================
Comment at: mlir/docs/PassManagement.md:259
- // Mark specific analyses as preserved. This is used if some transformation
+ // Mark-specific analyses as preserved. This is used if some transformation
// was performed, but some analyses were either unaffected or explicitly
----------------
Doesn't make sense
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122990/new/
https://reviews.llvm.org/D122990
More information about the llvm-commits
mailing list