[PATCH] D122990: Added new file & improved inclusivity
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 3 03:03:27 PDT 2022
xbolva00 added inline comments.
================
Comment at: README.md:122
+participants to all modes of communication within the project.
\ No newline at end of file
----------------
Revert this change here
================
Comment at: maypatch.patch:1
+diff --git a/clang/test/CodeGen/c-unicode.c b/clang/test/CodeGen/c-unicode.c
+index 13d4bbfb71e8..3a0c561908c7 100644
----------------
Remove this file
================
Comment at: mlir/docs/Interfaces.md:127
respectively. These classes take, as a template parameter, a `Traits` class that
-defines a `Concept` and a `Model` class. These classes provide an implementation
+defines a `Concept` and a `Model` class. These classes provides an implementation
of concept-based polymorphism, where the `Concept` defines a set of virtual
----------------
Why?
Please ensure that your corrections are actually correct.
================
Comment at: mlir/docs/OpDefinitions.md:3
-In addition to specializing the `mlir::Op` C++ template, MLIR also supports
+In addition to specializing int the `mlir::Op` C++ template, MLIR also supports
defining operations and data types in a table-driven manner. This is achieved
----------------
Strange change
================
Comment at: mlir/docs/PassManagement.md:911
computation, via the `PassInstrumentation` class. This class provides hooks into
-the PassManager that observe various events:
+the PassManager that observes various events:
----------------
hooks ... observe. Seems ok, no?
================
Comment at: mlir/docs/README.md:7
+See [this](https://github.com/llvm/mlir-www) for the website's generation information.
\ No newline at end of file
----------------
Add new line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122990/new/
https://reviews.llvm.org/D122990
More information about the llvm-commits
mailing list