[PATCH] D122909: [InstCombine] limit icmp fold with sub if other sub user is a phi

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 2 15:13:52 PDT 2022


spatel added a comment.

In D122909#3422897 <https://reviews.llvm.org/D122909#3422897>, @lebedev.ri wrote:

> It seems like something for a late undo pass to deal with.

Agree, but the comments in https://github.com/llvm/llvm-project/issues/54558 suggested there wasn't a quick fix, and there are already one-use limitations here, so that's why I proposed a fast fix for the regression. Do you object to this change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122909/new/

https://reviews.llvm.org/D122909



More information about the llvm-commits mailing list