[llvm] d0abdc2 - [Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources

[Martin Storsjö via llvm-commits]

Author: Martin Storsjö
Date: 2022-04-02T23:58:31+03:00
New Revision: d0abdc22b877159b2b18b3f683b7131341ce37af

URL: https://github.com/llvm/llvm-project/commit/d0abdc22b877159b2b18b3f683b7131341ce37af
DIFF: https://github.com/llvm/llvm-project/commit/d0abdc22b877159b2b18b3f683b7131341ce37af.diff

LOG: [Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources

COFF symbols don't have anything corresponding to a `.hidden` flag;
both GNU binutils as and LLVM's built-in assembler errors out on
these directives.

This reverts one part of
7f05aa2d4c36d6d53f97ac3e0db30ec600abbc62, fixing builds for
mingw x86_64.

Differential Revision: https://reviews.llvm.org/D122893

Added: 
    

Modified: 
    llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
    llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
    llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
    llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S b/llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
index ef19edbbed4ea..bb58d2ae64b13 100644
--- a/llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
+++ b/llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
@@ -1,6 +1,4 @@
 .intel_syntax noprefix
-.hidden _blake3_hash_many_avx2
-.hidden blake3_hash_many_avx2
 .global _blake3_hash_many_avx2
 .global blake3_hash_many_avx2
 .section .text

diff  --git a/llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S b/llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
index 6d17cbdb0c876..e10b9f36cbccb 100644
--- a/llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
+++ b/llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
@@ -1,11 +1,5 @@
 .intel_syntax noprefix
 
-.hidden _blake3_hash_many_avx512
-.hidden blake3_hash_many_avx512
-.hidden blake3_compress_in_place_avx512
-.hidden _blake3_compress_in_place_avx512
-.hidden blake3_compress_xof_avx512
-.hidden _blake3_compress_xof_avx512
 .global _blake3_hash_many_avx512
 .global blake3_hash_many_avx512
 .global blake3_compress_in_place_avx512

diff  --git a/llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S b/llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
index 66470fe067806..8852ba5976e15 100644
--- a/llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
+++ b/llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
@@ -1,10 +1,4 @@
 .intel_syntax noprefix
-.hidden blake3_hash_many_sse2
-.hidden _blake3_hash_many_sse2
-.hidden blake3_compress_in_place_sse2
-.hidden _blake3_compress_in_place_sse2
-.hidden blake3_compress_xof_sse2
-.hidden _blake3_compress_xof_sse2
 .global blake3_hash_many_sse2
 .global _blake3_hash_many_sse2
 .global blake3_compress_in_place_sse2

diff  --git a/llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S b/llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
index 749a84d7f6faa..60d0a4042e71d 100644
--- a/llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
+++ b/llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
@@ -1,10 +1,4 @@
 .intel_syntax noprefix
-.hidden blake3_hash_many_sse41
-.hidden _blake3_hash_many_sse41
-.hidden blake3_compress_in_place_sse41
-.hidden _blake3_compress_in_place_sse41
-.hidden blake3_compress_xof_sse41
-.hidden _blake3_compress_xof_sse41
 .global blake3_hash_many_sse41
 .global _blake3_hash_many_sse41
 .global blake3_compress_in_place_sse41