[PATCH] D122884: [Support] [BLAKE3] Fix compilation with CMAKE_OSX_ARCHITECTURES

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 2 13:57:31 PDT 2022


mstorsjo added a comment.

In D122884#3422812 <https://reviews.llvm.org/D122884#3422812>, @akyrtzi wrote:

> LGTM, but could you also include a `FIXME` note to indicate need to handle this kind of CMake setup for SIMD implementations, potentially using your alternative suggestion?

Sure, I can add such a todo.

FWIW I also noticed that this fixes builds for i386 (for any OS I'd believe) as the blake3 C code autoenables SIMD for i386 too, but those implementations are only available via the intrinsics sources (which are trickier to hook up in cmake, which we don't enable here).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122884/new/

https://reviews.llvm.org/D122884



More information about the llvm-commits mailing list