[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/test/CodeGen/memtag-attr.cpp:18
+// CHECK-NO-NOT: sanitize_memtag
+// CHECK-NO-NEXT: define {{.*}}HasSanitizeMemTag
+// CHECK-MEMTAG: Function Attrs: {{.*}} sanitize_memtag
----------------
By placing a space before `HasSanitizeMemTag` and placing a `(`, we test that the function name is exact.


================
Comment at: clang/test/Driver/memtag-ld.c:36
+
+// CHECK-ASYNC: ld{{.*}} "-memtag-mode=async"
+// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode=
----------------
This will be easier to read if you make the strings after `:` aligned.

Is `-memtag-mode=async` `--android-memtag-mode=async` now?


================
Comment at: clang/test/Driver/memtag-ld.c:38
+// CHECK-DEFAULT-MODE-NOT: ld{{.*}} "--android-memtag-mode=
+// CHECK-HEAP: "--android-memtag-heap"
+// CHECK-NO-HEAP-NOT: "--android-memtag-heap"
----------------
Prefer `CHECK-HEAP-SAME` to `CHECK-HEAP` whenever feasible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118948/new/

https://reviews.llvm.org/D118948