[PATCH] D119965: [LICM][PhaseOrder] Don't speculate in LICM until after running loop rotate

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 17:04:08 PDT 2022


Carrot added a comment.

In D119965#3423713 <https://reviews.llvm.org/D119965#3423713>, @lebedev.ri wrote:

> If this is really as simple as all the incoming values being identical instructions with identical arguments, then it seems like a simple extension of the `InstCombinerImpl::foldPHIArgOpIntoPHI()`

foldPHIArgOpIntoPHI requires all operands are used by PHI only. In our case or instruction in BB3 has other users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119965/new/

https://reviews.llvm.org/D119965



More information about the llvm-commits mailing list