[lld] 663a7fa - [lld/mac] Tweak a few comments

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 16:32:15 PDT 2022


Author: Nico Weber
Date: 2022-04-01T19:32:07-04:00
New Revision: 663a7fa712827c42f5ad62c64fda374d24dbf00d

URL: https://github.com/llvm/llvm-project/commit/663a7fa712827c42f5ad62c64fda374d24dbf00d
DIFF: https://github.com/llvm/llvm-project/commit/663a7fa712827c42f5ad62c64fda374d24dbf00d.diff

LOG: [lld/mac] Tweak a few comments

Addresses review feedback I had missed on https://reviews.llvm.org/D122624

No behavior change.

Differential Revision: https://reviews.llvm.org/D122904

Added: 
    

Modified: 
    lld/MachO/ConcatOutputSection.cpp
    lld/test/MachO/arm64-thunk-visibility.s

Removed: 
    


################################################################################
diff  --git a/lld/MachO/ConcatOutputSection.cpp b/lld/MachO/ConcatOutputSection.cpp
index 0e70d69f7aa0f..1aa21d6c7bb1b 100644
--- a/lld/MachO/ConcatOutputSection.cpp
+++ b/lld/MachO/ConcatOutputSection.cpp
@@ -84,15 +84,17 @@ void ConcatOutputSection::addInput(ConcatInputSection *input) {
 //   distant call sites might be unable to reach the same thunk, so multiple
 //   thunks are necessary to serve all call sites in a very large program. A
 //   thunkInfo stores state for all thunks associated with a particular
-//   function: (a) thunk symbol, (b) input section containing stub code, and
-//   (c) sequence number for the active thunk incarnation. When an old thunk
-//   goes out of range, we increment the sequence number and create a new
-//   thunk named <FUNCTION>.thunk.<SEQUENCE>.
+//   function:
+//     (a) thunk symbol
+//     (b) input section containing stub code, and
+//     (c) sequence number for the active thunk incarnation.
+//   When an old thunk goes out of range, we increment the sequence number and
+//   create a new thunk named <FUNCTION>.thunk.<SEQUENCE>.
 //
-// * A thunk consists of (a) a Defined symbol pointing to
-//   (b) an InputSection holding machine instructions (similar to a MachO
-//   stub), and (c) Reloc(s) that reference the real function for fixing-up
-//   the stub code.
+// * A thunk consists of
+//     (a) a Defined symbol pointing to
+//     (b) an InputSection holding machine code (similar to a MachO stub), and
+//     (c) relocs referencing the real function for fixing up the stub code.
 //
 // * std::vector<InputSection *> MergedInputSection::thunks: A vector parallel
 //   to the inputs vector. We store new thunks via cheap vector append, rather

diff  --git a/lld/test/MachO/arm64-thunk-visibility.s b/lld/test/MachO/arm64-thunk-visibility.s
index 0a697adf1357a..5fa195f8b1156 100644
--- a/lld/test/MachO/arm64-thunk-visibility.s
+++ b/lld/test/MachO/arm64-thunk-visibility.s
@@ -1,7 +1,7 @@
 # REQUIRES: aarch64
 
 # foo.s and bar.s both contain TU-local symbols (think static function)
-# with the same name, and both need a thunk..  This tests that ld64.lld doesn't
+# with the same name, and both need a thunk.  This tests that ld64.lld doesn't
 # create a duplicate symbol for the two functions.
 
 # Test this both when the TU-local symbol is the branch source or target,


        


More information about the llvm-commits mailing list