[PATCH] D122843: [lld-macho] Include output filename in UUID hash

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: lld/test/MachO/uuid.s:6
+# RUN: %lld -lSystem %t/test.o -o %t/b
+# RUN: llvm-dwarfdump --uuid %t/a | awk '{print $2}' > %t/uuida
+# RUN: llvm-dwarfdump --uuid %t/b | awk '{print $2}' > %t/uuidb
----------------
int3 wrote:
> lgrey wrote:
> > int3 wrote:
> > > jfyi, the `awk` isn't super necessary since `FileCheck` does substring matching by default. but I'm fine if you prefer this for clarity
> > We need it for `cmp` to work (but maybe there are better ways to check for string equality? I went this way after I couldn't figure out how to do it purely via FileCheck)
> d'oh, yes, I forgot that `llvm-dwarfdump --uuid` included the filename in its output. nevermind :)
just FYI, this is the only test that invokes `awk` AFAICT and it's breaking our windows buildbot which doesn't have `awk`
arguably we shouldn't be using gnuwin32 and should upgrade to git bash

I've marked this test as unsupported on windows in 79a9fe6c8afeff727ac60e6c7abe24f02df5a9a4


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122843/new/

https://reviews.llvm.org/D122843