[PATCH] D122251: [lit] Use sharding for GoogleTest format

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 15:28:45 PDT 2022


ychen marked an inline comment as done.
ychen added inline comments.


================
Comment at: llvm/utils/lit/lit/formats/googletest.py:170
+
+        remove_gtest(discovered_tests)
+        gtests = [t for t in selected_tests if t.gtest_json_file]
----------------
yln wrote:
> This will still change the passed-in lists, right?
That's right. It is by reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251



More information about the llvm-commits mailing list