[PATCH] D77945: Fixing llvm-shlib to check for the correct host triple on Windows x86

Fri Apr 1 15:14:16 PDT 2022

mstorsjo added a comment.

In D77945#3423531 <https://reviews.llvm.org/D77945#3423531>, @tstellar wrote:

> Why is i686-pc-windows-msvc is correct triple?

See D109493 <https://reviews.llvm.org/D109493> for a more complete explanation of the issue at hand (sorry I wasn't aware of this patch when I made that one). D47381 <https://reviews.llvm.org/D47381> changed GetHostTriple.cmake so that it by default sets such a triple - previously it was `i686-pc-win32` but after that commit, that cmake file sets it to `i686-pc-windows-msvc` instead - but this file wasn't updated correctly in sync. D109493 <https://reviews.llvm.org/D109493> which has been committed made the pattern more flexible to accept both forms.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77945/new/

https://reviews.llvm.org/D77945