[PATCH] D122915: [AArch64] UBFM fold in the MIPeepholeOpt.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 15:06:36 PDT 2022


efriedma added a comment.

It looks like the lsr+bfi is coming out of tryBitfieldInsertOpFromOr in AArch64ISelDAGToDAG.cpp.  I see two possible alternatives:

1. Enhance tryBitfieldInsertOpFromOr to detect when it's shifting a shift.
2. Form the BFM op as a DAGCombine, instead of waiting for isel.

This MI peephole seems unlikely to be useful outside of this one case, so I think I'd prefer to fix the existing logic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122915/new/

https://reviews.llvm.org/D122915



More information about the llvm-commits mailing list