[PATCH] D122814: Functionality Added to CMAKE

Fri Apr 1 11:08:08 PDT 2022

phosek added a comment.

In D122814#3422965 <https://reviews.llvm.org/D122814#3422965>, @beanz wrote:

> Looping in a few others with CMake experience.
>
> `NONE` isn't really a `CMAKE_BUILD_TYPE` in the normal flow (see: https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html), and it would have undefined behavior inside LLVM because we key quite a few things off the `CMAKE_BUILD_TYPE`, so I'm a little concerned about this change.
>
> I'm not sure why you think supporting `NONE` is a good practice, my opinion is that an undefined build type would be a bad thing to support...

I agree, I haven't yet encountered `NONE` in CMake projects and it's not clear to me why we should support it in LLVM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122814/new/

https://reviews.llvm.org/D122814