[PATCH] D122371: [mlir][OpenMP][IRBuilder] Add support for nowait on single construct

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2954
+    if (auto CI = dyn_cast<CallInst>(cur)) {
+      EXPECT_FALSE(CI->getCalledFunction()->getName() == "__kmpc_barrier");
+    }
----------------
It seems this EXPECT_FALSE is never executed, causing it to be flagged in my "Rotten Green Tests" work.  Perhaps the loop could be rewritten to be more similar to the ThenBB check?
```
CallInst *ExitCI = nullptr;
for (auto &FI : *ExitBB) {
  Instruction *cur = &FI;
  if (auto CI = dyn_cast<CallInst>(cur)) {
    if (CI->getCalledFunction()->getName() == "__kmpc_barrier") {
      ExitCI = CI;
      break;
    }
  }
}
EXPECT_EQ(ExitCI, nullptr);
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122371/new/

https://reviews.llvm.org/D122371