[PATCH] D122904: [lld/mac] Tweak a few comments

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: lld-macho.
Herald added projects: lld-macho, All.
thakis requested review of this revision.

Addresses review feedback I had missed on https://reviews.llvm.org/D122624

No behavior change.


https://reviews.llvm.org/D122904

Files:
  lld/MachO/ConcatOutputSection.cpp
  lld/test/MachO/arm64-thunk-visibility.s


Index: lld/test/MachO/arm64-thunk-visibility.s
===================================================================
--- lld/test/MachO/arm64-thunk-visibility.s
+++ lld/test/MachO/arm64-thunk-visibility.s
@@ -1,7 +1,7 @@
 # REQUIRES: aarch64
 
 # foo.s and bar.s both contain TU-local symbols (think static function)
-# with the same name, and both need a thunk..  This tests that ld64.lld doesn't
+# with the same name, and both need a thunk.  This tests that ld64.lld doesn't
 # create a duplicate symbol for the two functions.
 
 # Test this both when the TU-local symbol is the branch source or target,
Index: lld/MachO/ConcatOutputSection.cpp
===================================================================
--- lld/MachO/ConcatOutputSection.cpp
+++ lld/MachO/ConcatOutputSection.cpp
@@ -84,15 +84,17 @@
 //   distant call sites might be unable to reach the same thunk, so multiple
 //   thunks are necessary to serve all call sites in a very large program. A
 //   thunkInfo stores state for all thunks associated with a particular
-//   function: (a) thunk symbol, (b) input section containing stub code, and
-//   (c) sequence number for the active thunk incarnation. When an old thunk
-//   goes out of range, we increment the sequence number and create a new
-//   thunk named <FUNCTION>.thunk.<SEQUENCE>.
+//   function:
+//     (a) thunk symbol
+//     (b) input section containing stub code, and
+//     (c) sequence number for the active thunk incarnation.
+//   When an old thunk goes out of range, we increment the sequence number and
+//   create a new thunk named <FUNCTION>.thunk.<SEQUENCE>.
 //
-// * A thunk consists of (a) a Defined symbol pointing to
-//   (b) an InputSection holding machine instructions (similar to a MachO
-//   stub), and (c) Reloc(s) that reference the real function for fixing-up
-//   the stub code.
+// * A thunk consists of
+//     (a) a Defined symbol pointing to
+//     (b) an InputSection holding machine code (similar to a MachO stub), and
+//     (c) relocs referencing the real function for fixing up the stub code.
 //
 // * std::vector<InputSection *> MergedInputSection::thunks: A vector parallel
 //   to the inputs vector. We store new thunks via cheap vector append, rather


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122904.419749.patch
Type: text/x-patch
Size: 2237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220401/ce8ad04d/attachment.bin>