[PATCH] D122746: [AIX][XCOFF] print unsupported message for llvm-ar big archive write operation

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 06:41:03 PDT 2022


jsji accepted this revision.
jsji added a comment.

LGTM. Thanks @DiggerLin !



================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:948
+    if (Kind == object::Archive::K_AIXBIG)
+      fail("unsupported big AIX write operation");
     break;
----------------
nit: Can we update the message to be more verbose? eg: `big archive writer operation on AIX not yet supported`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122746/new/

https://reviews.llvm.org/D122746



More information about the llvm-commits mailing list