[PATCH] D122814: Functionality Added to CMAKE

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added reviewers: kbarton, beanz.
aaron.ballman added a comment.

In D122814#3422183 <https://reviews.llvm.org/D122814#3422183>, @ps-19 wrote:

> i have seen some cases in repos where no build variants are found and that creates error in building at some moment. It's good standard practice to include NONE type even we don't need this time, else everything is fine for now, i may close the patch for now.

I don't know enough about CMake best practices to know whether this is or isn't a standard practice (it's not from what I know, but I don't know much in this space). Personally, I think if the user ends up with "none" as the build type, an error is a kindness for them because something's gone weird in the build system. Adding a few more reviewers in case I'm wrong though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122814/new/

https://reviews.llvm.org/D122814