[PATCH] D122871: Clang-Formatting
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 1 04:56:30 PDT 2022
aaron.ballman added a comment.
In D122871#3422061 <https://reviews.llvm.org/D122871#3422061>, @ps-19 wrote:
> okay now i understand the issue completely.
> If i just mentioned that i am formatting a test file it would be correct then according to my patch.
We don't typically reformat whole files for no reason (it adds churn to the code base which makes things like `git blame` harder to use). We will accept a reformat like this when there's going to be immediate follow-up work in the file where having it properly formatted will make the second code review easier to understand, but that doesn't sound like the case here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122871/new/
https://reviews.llvm.org/D122871
More information about the llvm-commits
mailing list