[PATCH] D122893: [Support] [BLAKE3] Remove .hidden directives from windows-gnu assembly sources

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: akyrtzi.
Herald added subscribers: dexonsmith, hiraditya.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

COFF symbols don't have anything corresponding to a `.hidden` flag;
both GNU binutils as and LLVM's built-in assembler errors out on
these directives.

This reverts one part of
7f05aa2d4c36d6d53f97ac3e0db30ec600abbc62 <https://reviews.llvm.org/rG7f05aa2d4c36d6d53f97ac3e0db30ec600abbc62>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122893

Files:
  llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
  llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S


Index: llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
===================================================================
--- llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
+++ llvm/lib/Support/BLAKE3/blake3_sse41_x86-64_windows_gnu.S
@@ -1,10 +1,4 @@
 .intel_syntax noprefix
-.hidden blake3_hash_many_sse41
-.hidden _blake3_hash_many_sse41
-.hidden blake3_compress_in_place_sse41
-.hidden _blake3_compress_in_place_sse41
-.hidden blake3_compress_xof_sse41
-.hidden _blake3_compress_xof_sse41
 .global blake3_hash_many_sse41
 .global _blake3_hash_many_sse41
 .global blake3_compress_in_place_sse41
Index: llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
===================================================================
--- llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
+++ llvm/lib/Support/BLAKE3/blake3_sse2_x86-64_windows_gnu.S
@@ -1,10 +1,4 @@
 .intel_syntax noprefix
-.hidden blake3_hash_many_sse2
-.hidden _blake3_hash_many_sse2
-.hidden blake3_compress_in_place_sse2
-.hidden _blake3_compress_in_place_sse2
-.hidden blake3_compress_xof_sse2
-.hidden _blake3_compress_xof_sse2
 .global blake3_hash_many_sse2
 .global _blake3_hash_many_sse2
 .global blake3_compress_in_place_sse2
Index: llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
===================================================================
--- llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
+++ llvm/lib/Support/BLAKE3/blake3_avx512_x86-64_windows_gnu.S
@@ -1,11 +1,5 @@
 .intel_syntax noprefix
 
-.hidden _blake3_hash_many_avx512
-.hidden blake3_hash_many_avx512
-.hidden blake3_compress_in_place_avx512
-.hidden _blake3_compress_in_place_avx512
-.hidden blake3_compress_xof_avx512
-.hidden _blake3_compress_xof_avx512
 .global _blake3_hash_many_avx512
 .global blake3_hash_many_avx512
 .global blake3_compress_in_place_avx512
Index: llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
===================================================================
--- llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
+++ llvm/lib/Support/BLAKE3/blake3_avx2_x86-64_windows_gnu.S
@@ -1,6 +1,4 @@
 .intel_syntax noprefix
-.hidden _blake3_hash_many_avx2
-.hidden blake3_hash_many_avx2
 .global _blake3_hash_many_avx2
 .global blake3_hash_many_avx2
 .section .text


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122893.419714.patch
Type: text/x-patch
Size: 2298 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220401/0fdd4dcd/attachment.bin>