[PATCH] D122890: [2/3] TLS loads optimization (hoist)

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 04:00:22 PDT 2022


xiangzhangllvm added a comment.

In D122890#3421936 <https://reviews.llvm.org/D122890#3421936>, @lebedev.ri wrote:

> I'm not really sure that attribute should be there, especially after the optimization is enabled by default and cl::opt is inverted.

Yes, In fact I saw it before, due to, D122866 <https://reviews.llvm.org/D122866>,  I prefer keep it here.
And if customer strongly require the option, I may need to re-active the D122558 <https://reviews.llvm.org/D122558>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122890/new/

https://reviews.llvm.org/D122890



More information about the llvm-commits mailing list