[PATCH] D115747: [AMDGPU] Flush the vmcnt counter in loop preheader when necessary

Fri Apr 1 02:37:44 PDT 2022

foad added inline comments.
Herald added a subscriber: hsmhsm.

================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-vmcnt-loop.mir:4
+
+--- |
+
----------------
I think you can remove this whole IR section.

================
Comment at: llvm/test/CodeGen/AMDGPU/waitcnt-vmcnt-loop.mir:56
+# GFX9-LABEL: waitcnt_vm_loop
+# GFX9-LABEL: bb.0:
+# GFX9: S_WAITCNT 39
----------------
It's pretty unusual to use the -LABEL suffix for an actual label. Normally it is only used for the start of each function. Did you have a special reason for doing it this way?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115747/new/

https://reviews.llvm.org/D115747