[PATCH] D120329: [SelectionDAG] Emit calls to __divei4 and friends for division/remainder of large integers

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 1 01:54:26 PDT 2022


pengfei added a comment.
Herald added a subscriber: StephenFan.

In D120329#3384553 <https://reviews.llvm.org/D120329#3384553>, @pengfei wrote:

> In D120329#3384538 <https://reviews.llvm.org/D120329#3384538>, @LuoYuanke wrote:
>
>> Can we land this patch? I think we can update test case after that if there is better idea for the parameter passing/returning.
>
> I'm fine with it. If fact, I think we may need to reflect the ABI lowering in the backend. That says the `i129` will be good tests for the future work, though we may not work on it very recently.

FYI. X86 psABI has defined the representation of _BitInt(N) https://gitlab.com/x86-psABIs/x86-64-ABI/-/commit/ceff85b232117f15296da5a4ecc98e25a0547093
I can see both front end and backend need to change. FE should always emit `i(((N + 63) / 64) * 64)` type, while BE should take all non pow of 2 `i(((N + 63) / 64) * 64)` type as legal.
Thought?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120329/new/

https://reviews.llvm.org/D120329



More information about the llvm-commits mailing list