[PATCH] D120714: [CodeGen] Place SDNode debug ID declaration under appropriate #if
Daniil Kovalev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 31 23:48:27 PDT 2022
kovdan01 added a comment.
In D120714#3417416 <https://reviews.llvm.org/D120714#3417416>, @dexonsmith wrote:
> Hmm, the tests look much harder to read now. I'm not sure that's better.
>
> Seems simpler/cleaner to use `REQUIRES: asserts, abi-breaking-checks`.
OK, makes sense. Updated the patch following your advice.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120714/new/
https://reviews.llvm.org/D120714
More information about the llvm-commits
mailing list