[PATCH] D122558: [2/3] TLS loads optimization (hoist)

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 31 18:17:11 PDT 2022


xiangzhangllvm added a comment.

In D122558#3420158 <https://reviews.llvm.org/D122558#3420158>, @efriedma wrote:

> The problem isn't really the amount of code needed to support the option... it's that a formally documented option needs to have clear semantics, and we need to support it forever.  We really don't like options that say "turn off optimization X that has no user-visible semantics".  I mean, even if you pass -mno-tls-load-hoist, we might end up hoisting anyway, depending on what you're doing with the address...

Thank you! I begin more clear about the principle of Clang Driver option.
(It should prefer user-visible, functional, performance with visible control)
Let me abandon this patch and enable the optimization in default in PIC mode.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122558/new/

https://reviews.llvm.org/D122558



More information about the llvm-commits mailing list