[PATCH] D122843: [lld-macho] Include output filename in UUID hash
Keith Smiley via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 31 12:05:49 PDT 2022
keith added inline comments.
================
Comment at: lld/MachO/Writer.cpp:1089
+ // don't get the same UUID.
+ hashes[chunks.size()] = xxHash64(sys::path::filename(config->outputFile));
uint64_t digest = xxHash64({reinterpret_cast<uint8_t *>(hashes.data()),
----------------
I think this needs to use `final_output` and not `output`, the difference being when you use clang to compile a multi-arch binary `output` is a randomized name, so this breaks hermetic builds
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122843/new/
https://reviews.llvm.org/D122843
More information about the llvm-commits
mailing list