[PATCH] D121430: [PowerPC] Fix lowering of byval parameters for sizes greater than 8 bytes.

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.

LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:4451
         }
-        SDValue Store = DAG.getStore(Val.getValue(1), dl, Val, Addr,
-                                     MachinePointerInfo(&*FuncArg, j));
+        unsigned StoreSize = std::min(PtrByteSize, (ObjSize - j)) * 8;
+        EVT ObjType = EVT::getIntegerVT(*DAG.getContext(), StoreSize);
----------------
Minor nit: maybe indicate that these sizes are in bits in the names - `{Store|Load}SizeInBits`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121430/new/

https://reviews.llvm.org/D121430