[PATCH] D122818: [AMDGPU][GlobalISel] Add end to end IR tests for add/sub with overflow

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/addo.ll:6
+
+define i32 @uaddo_i32(i32 %a, i32 %b) {
+; GFX7-LABEL: uaddo_i32:
----------------
Add v_ prefix to these tests.

Also a few with mixed VGPR and SGPR inputs


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/addo.ll:591
+
+declare {i32, i1} @llvm.uadd.with.overflow.i32(i32 %a, i32 %b)
+declare {i64, i1} @llvm.uadd.with.overflow.i64(i64 %a, i64 %b)
----------------
Can you also test i8/i16 and then some odd sizes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122818/new/

https://reviews.llvm.org/D122818