[PATCH] D122081: Add DXILPrepare CodeGen pass

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILPrepare.cpp:97
+        IRBuilder<> Builder(&BB);
+        SmallVector<Instruction *, 4> FNegs;
+        for (auto &I : BB) {
----------------
Why the three loops here? I think you just need one if you use make_early_inc_range.


================
Comment at: llvm/lib/Target/DirectX/DirectX.h:14
+
+#include "llvm/PassRegistry.h"
+namespace llvm {
----------------
This include looks unnecessary given the forward declaration below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122081/new/

https://reviews.llvm.org/D122081