[PATCH] D121052: [lld-macho][nfc] Reduce size of icfEqClass hash

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 13:33:52 PDT 2022


int3 added inline comments.


================
Comment at: lld/MachO/ICF.cpp:375
   std::vector<ConcatInputSection *> hashable;
   uint64_t icfUniqueID = inputSections.size();
   for (ConcatInputSection *isec : inputSections) {
----------------
thakis wrote:
> Should this be a uint32_t now? (doesn't matter in practice; I just found it confusing when I was reading the code just now)
yep, forgot to change this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121052/new/

https://reviews.llvm.org/D121052



More information about the llvm-commits mailing list