[PATCH] D122615: Early return in constrainOperandRegClass()

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/RegisterBankInfo.h:644
+  /// false otherwise.
+  static bool needToConstrainGenericRegister(Register Reg,
+                                             const TargetRegisterClass &RC,
----------------
I don't see the point of having this be both a separate utility function and a static member. It should be either one or the other


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:46
+                                     const TargetRegisterClass &RegClass) {
+  return RBI.needToConstrainGenericRegister(Reg, RegClass, MRI);
+}
----------------
Why call a static method through RBI?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122615/new/

https://reviews.llvm.org/D122615