[PATCH] D116952: [ConstantFolding] Respect denormal handling mode attributes when folding instructions

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 11:21:21 PDT 2022


spatel added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1056
+    break;
+  case Instruction::FNeg:
+  case Instruction::FAdd:
----------------
fneg is not a computational FP operation; it's a signbit operation. For example on x86 with SSE, it's implemented with a vector integer xor instruction, so it is not affected by denorm FP mode. I'm not sure what happens on targets that have a real fneg instruction.

Either way, we need at least one test to check the behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116952/new/

https://reviews.llvm.org/D116952



More information about the llvm-commits mailing list