[PATCH] D119148: [LoopUnroll] Always respect user unroll pragma

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 11:18:33 PDT 2022


efriedma added a comment.

PragmaUnrollThreshold has other uses; are you intentionally leaving those alone?

I'm not confident it makes sense to "respect the user" here; nobody really benefits from crashing the compiler.  But I don't have a strong preference here; "#pragma unroll" is rare enough that I don't expect much practical impact either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119148/new/

https://reviews.llvm.org/D119148



More information about the llvm-commits mailing list