[PATCH] D122723: [RISCV] [NFC] Add Immediate tests for the cmov instruction

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 30 09:30:25 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/i32-icmp.ll:211
 ; RV32I-NEXT:    ret
-; 4294965247 signed extend is -2049
-  %1 = icmp ugt i32 %a, 4294965247
+  %1 = icmp ugt i32 %a, -2049
   %2 = zext i1 %1 to i32
----------------
Why are you changing unsigned constants to signed? Wasn't unsigned requested in the previous review?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122723/new/

https://reviews.llvm.org/D122723



More information about the llvm-commits mailing list