[PATCH] D122737: [AMDGPU] Fix crash in SIOptimizeExecMaskingPreRA

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Could also use a MIR test



================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:425
             !SingleExecUser->getOperand(Idx).isImplicit() &&
-            TII->isOperandLegal(*SingleExecUser, Idx, &I->getOperand(1))) {
+            (SingleExecUser->isCopy() ||
+             TII->isOperandLegal(*SingleExecUser, Idx, &I->getOperand(1)))) {
----------------
A COPY isn't the only case where this happens though


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp:427
+             TII->isOperandLegal(*SingleExecUser, Idx, &I->getOperand(1)))) {
           LLVM_DEBUG(dbgs() << "Redundant EXEC COPY: " << *I << '\n');
           LIS->RemoveMachineInstrFromMaps(*I);
----------------
Newline is redundant here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122737/new/

https://reviews.llvm.org/D122737