[PATCH] D122653: [AMDGPU] Document the intended semantics of llvm.amdgcn.s.buffer.load

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:953
+// Generate a buffer_load instruction that may be optimized to s_buffer_load if
+// the offset argument is uniform.
 def int_amdgcn_s_buffer_load : Intrinsic <
----------------
alex-t wrote:
> Does this imply that the divergent descriptor and uniform offset result in s_buffer_load too? 
For this patch I just wanted to say what is special about llvm.amdgcn.s.buffer.load. I don't want to say anything about divergent descriptors because (a) they are not fully supported yet (globalisel inserts a waterfall loop for them but selectiondag does not) and (b) if/when we do document that they are supported, it would apply to many intrinsics (all the ones that take a descriptor argument) not just this one.

(But the answer to your question is yes, I would expect divergent descriptor and uniform offset to result in s_buffer_load.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122653/new/

https://reviews.llvm.org/D122653